-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Update instructions #2895
Conversation
Additional details for using redis or postgres installed outside docker
README.md
Outdated
@@ -47,17 +47,18 @@ For a manual self-hosted production installation these are the recommended steps | |||
1. Setup the database with `yarn db:migrate`. Production assumes an SSL connection to the database by default, if | |||
Postgres is on the same machine and is not SSL you can migrate with `yarn db:migrate --env=production-ssl-disabled`, for example: | |||
|
|||
`docker run --rm outlinewiki/outline yarn db:migrate` | |||
`docker run --rm --env-file=.env outlinewiki/outline yarn db:migrate` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would prefer to revert these lines, it makes the assumption that your environment variables are stored in a file. We describe this in the first step.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Recently I was confused about 5 minutes why command doesn't work. Copy paste instruction is what we need. For now I need to pass --env
parameter to every docker command, is it right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, it depends – what's copy and paste for your setup is not for another. Many environments will inject environment variables through other mechanisms
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, I'll remove that. Thank you. Please share your thoughts how to pass env variables in another way. Maybe my workaround not so perfect for production mode.
Co-authored-by: Tom Moor <tom.moor@gmail.com>
Additional details for using redis or postgres installed outside docker