Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Update instructions #2895

Merged
merged 3 commits into from
Jan 9, 2022
Merged

docs: Update instructions #2895

merged 3 commits into from
Jan 9, 2022

Conversation

max-mykhailenko
Copy link
Contributor

Additional details for using redis or postgres installed outside docker

Additional details for using redis or postgres installed outside docker
@auto-assign auto-assign bot requested a review from tommoor January 3, 2022 08:44
@CLAassistant
Copy link

CLAassistant commented Jan 3, 2022

CLA assistant check
All committers have signed the CLA.

README.md Outdated
@@ -47,17 +47,18 @@ For a manual self-hosted production installation these are the recommended steps
1. Setup the database with `yarn db:migrate`. Production assumes an SSL connection to the database by default, if
Postgres is on the same machine and is not SSL you can migrate with `yarn db:migrate --env=production-ssl-disabled`, for example:

`docker run --rm outlinewiki/outline yarn db:migrate`
`docker run --rm --env-file=.env outlinewiki/outline yarn db:migrate`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would prefer to revert these lines, it makes the assumption that your environment variables are stored in a file. We describe this in the first step.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Recently I was confused about 5 minutes why command doesn't work. Copy paste instruction is what we need. For now I need to pass --env parameter to every docker command, is it right?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, it depends – what's copy and paste for your setup is not for another. Many environments will inject environment variables through other mechanisms

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I'll remove that. Thank you. Please share your thoughts how to pass env variables in another way. Maybe my workaround not so perfect for production mode.

README.md Outdated Show resolved Hide resolved
max-mykhailenko and others added 2 commits January 5, 2022 13:02
Co-authored-by: Tom Moor <tom.moor@gmail.com>
@tommoor tommoor changed the title Update instructions docs: Update instructions Jan 9, 2022
@tommoor tommoor merged commit ce27332 into outline:main Jan 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants