Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Metaculus date parsing #432

Merged
merged 1 commit into from
Dec 15, 2020
Merged

Fix Metaculus date parsing #432

merged 1 commit into from
Dec 15, 2020

Conversation

uvafan
Copy link
Contributor

@uvafan uvafan commented Dec 11, 2020

No description provided.

@uvafan uvafan requested a review from brachbach as a code owner December 11, 2020 03:06
brachbach
brachbach approved these changes Dec 14, 2020
View reviewed changes
Copy link
Member

@brachbach brachbach left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Would be nice to test this, but not sure how we would exactly and not a big deal
  2. lame that the tests are erratically failing. Any idea why? My current hypothesis is that we're getting rate-limited by the Metaculus API because we're hitting it too often across the 6 different times that we run the tests (run tests twice [branch + PR] * run tests on 3 Python versions)
    1. TBC if this is accurate, there's nothing wrong with your PR, but any PR would run into the same problem

@uvafan
Copy link
Contributor Author

uvafan commented Dec 14, 2020

  1. Would be nice to test this, but not sure how we would exactly and not a big deal

  2. lame that the tests are erratically failing. Any idea why? My current hypothesis is that we're getting rate-limited by the Metaculus API because we're hitting it too often across the 6 different times that we run the tests (run tests twice [branch + PR] * run tests on 3 Python versions)

    1. TBC if this is accurate, there's nothing wrong with your PR, but any PR would run into the same problem

On 1, yeah would be nice but don't think it's worth the time for us to do right now.
On 2, yeah I'm also guessing that we're getting rate-limited.

@uvafan uvafan merged commit c1531e2 into master Dec 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brachbach brachbach brachbach approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@uvafan @brachbach