Add '/' to Metacalculus questions url to remove redirect #428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brachbach
requested changes
Nov 3, 2020
There was a problem hiding this comment.
Nice!
Actually my current guess is that we do still want to allow redirects (remove allow_redirects=False) so that this code will still work if Metaculus ever changes their API URL in the future and adds a redirect to the new URL
Do you think that makes sense @zmpster?
|
Yeah, that makes sense. I was thinking disallowing redirect explicitly was a bit too cute. Removed that option! |
brachbach
approved these changes
Nov 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #363. There wasn't a great way to test this without exposing too much from the Metaculus class, thought if you disallow redirects, as I have done, but don't add the
/, the tests will fail.