Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: otiai10/copy
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v1.12.0
Choose a base ref
...
head repository: otiai10/copy
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v1.14.0
Choose a head ref
  • 13 commits
  • 16 files changed
  • 2 contributors

Commits on Sep 2, 2023

  1. [attempt by ycombinator] concurrent dcopy (#122) 

    * Use worker pool

* Introduce Concurrency() functional option

* Collect all errors

* Simplify type of Concurrency option

* Make channels buffered

* Make input channel unbuffered

* Logging for debugging

* 10x channel capacities

* 10x concurrency

* 100x concurrency

* 100x in channel

* Make output channel 1000x

* Reducing numWorkers multiplier by 1/10

* Removing numWorkers multiplier

* Reducing in channel capacity by 1/10

* Reducing output channel capacity by 1/10

* Reducing output channel capacity by further 1/10

* Remove input channel capacity multiplier

* Removing multiplication factor for output channel capacity

* Remove debugging statement

---------

Co-authored-by: Shaunak Kashyap <ycombinator@gmail.com>
    @ycombinator @otiai10
    ycombinator authored and otiai10 committed Sep 2, 2023
    Configuration menu
    Copy the full SHA
    a403ffc View commit details
    Browse the repository at this point in the history

  2. Revert "[attempt by ycombinator] concurrent dcopy (#122)" 

    This reverts commit a403ffc.
    @otiai10
    otiai10 committed Sep 2, 2023
    Configuration menu
    Copy the full SHA
    6a6d5f1 View commit details
    Browse the repository at this point in the history

Commits on Sep 3, 2023

  1. Add options for concurrent dcopy

    @otiai10
    otiai10 committed Sep 3, 2023
    Configuration menu
    Copy the full SHA
    78d861c View commit details
    Browse the repository at this point in the history

  2. Add tests for concurrent dcopy

    @otiai10
    otiai10 committed Sep 3, 2023
    Configuration menu
    Copy the full SHA
    4c9bb1f View commit details
    Browse the repository at this point in the history

  3. Implementation for concurrent dcopy

    @otiai10
    otiai10 committed Sep 3, 2023
    Configuration menu
    Copy the full SHA
    e88ee39 View commit details
    Browse the repository at this point in the history

  4. Update README

    @otiai10
    otiai10 committed Sep 3, 2023
    Configuration menu
    Copy the full SHA
    87cb224 View commit details
    Browse the repository at this point in the history

Commits on Sep 7, 2023

  1. Add more test files for case19 to fail 

    Since it acquires semaphore worker for directory and locks until it ends, there might be "never-ending" semaphore.
    @otiai10
    otiai10 committed Sep 7, 2023
    Configuration menu
    Copy the full SHA
    c165d68 View commit details
    Browse the repository at this point in the history

  2. Do not acquire semaphore worker for directory

    @otiai10
    otiai10 committed Sep 7, 2023
    Configuration menu
    Copy the full SHA
    79342f5 View commit details
    Browse the repository at this point in the history

  3. Remove unnecessary cancel context 

    errorgroup.WithContext can cancel sibling routines when a routine returns non-nil error.
See https://cs.opensource.google/go/x/sync/+/refs/tags/v0.3.0:errgroup/errgroup.go;l=40-48
    @otiai10
    otiai10 committed Sep 7, 2023
    Configuration menu
    Copy the full SHA
    a5478ea View commit details
    Browse the repository at this point in the history

  4. Refactor: Remove useless if-condition

    @otiai10
    otiai10 committed Sep 7, 2023
    Configuration menu
    Copy the full SHA
    3eebd94 View commit details
    Browse the repository at this point in the history

  5. Add benchmark test

    @otiai10
    otiai10 committed Sep 7, 2023
    Configuration menu
    Copy the full SHA
    0b8d7bd View commit details
    Browse the repository at this point in the history

  6. Change interface name: NumOfWorkers

    @otiai10
    otiai10 committed Sep 7, 2023
    Configuration menu
    Copy the full SHA
    4118a68 View commit details
    Browse the repository at this point in the history

Commits on Oct 2, 2023

  1. Merge pull request #123 from otiai10/feature/concurrent-dcopy 

    Feature/concurrent dcopy
    @otiai10
    otiai10 authored Oct 2, 2023
    Configuration menu
    Copy the full SHA
    fba066a View commit details
    Browse the repository at this point in the history
Loading