Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: jsonc/auto rule works even in flat config #298

Merged
merged 8 commits into from
Jan 23, 2024
Merged

feat: jsonc/auto rule works even in flat config #298

merged 8 commits into from
Jan 23, 2024

Conversation

ota-meshi
Copy link
Owner

No description provided.

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jan 23, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: d744e81

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
eslint-plugin-jsonc Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jan 23, 2024

⚠️ No Changeset found

Latest commit: 1ecacdd

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@ota-meshi ota-meshi merged commit a40f021 into master Jan 23, 2024
16 checks passed
@ota-meshi ota-meshi deleted the flat-auto branch January 23, 2024 00:53
@github-actions github-actions bot mentioned this pull request Jan 23, 2024
Merged
JounQin
JounQin reviewed Jan 23, 2024
View reviewed changes
lib/utils/get-auto-jsonc-rules-config/calculate-config-for-file.ts
@@ -0,0 +1,15 @@
import type { Linter } from "eslint";
// @ts-expect-error -- ignore
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the problem here?

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typescript gives an error saying synckit is an ESM package, but synckit can also be used with commonjs. I don't quite understand the correct way to configure typescript 😓

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll take a look and raise a PR for it.

@JounQin JounQin mentioned this pull request Jan 23, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JounQin JounQin JounQin left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ota-meshi @JounQin