Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tags from node #17

Merged
merged 1 commit into from
Aug 17, 2013
Merged

Tags from node #17

merged 1 commit into from
Aug 17, 2013

Conversation

giorgio-v
Copy link
Contributor

Chef tags are collected together with roles.

  • lib/chef-rundeck.rb:

Chef tags are collected together with roles.

* lib/chef-rundeck.rb:
@josephholsten
Copy link
Contributor

looks good (here's the diff ignoring whitespace changes)

@leftathome
Copy link
Contributor

Okay, now that we've got Travis up and running (... and passing), we can start merging in outstanding PRs. This one looks good and it's a valuable feature.

Mainly as a note for us maintainers, I'd like to see these when we merge this in:

  • A test checking to see that a Chef node object with tag X appears in the resource model as a node with tag X.
  • A test checking to see that a Chef node object with no tags still ends up with proper formatting in the resource model.

bscott pushed a commit that referenced this pull request Aug 17, 2013
@bscott bscott merged commit c133341 into oswaldlabs:master Aug 17, 2013
bscott pushed a commit that referenced this pull request Oct 3, 2013
bscott pushed a commit that referenced this pull request Oct 3, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants