Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Work with a client/node name of node[:fqdn] #11

Closed
josephholsten opened this issue Mar 7, 2012 · 5 comments
Closed

Work with a client/node name of node[:fqdn] #11

josephholsten opened this issue Mar 7, 2012 · 5 comments

Comments

@josephholsten
Copy link
Contributor

When using the "chef-client::config" recipe
And the Chef::Config[:node_name] == node["fqdn"]
Then "/etc/chef/client.rb" has no "node_name" attribute

So when using chef-client -c /etc/chef/client.rb
Then there is an "ArgumentError" with message "Cannot sign the request without a client name, check that :node_name is assigned"

Instead, if the config file contains no client name or node name
chef-client should use "node[:fqdn]"
@josephholsten
Copy link
Contributor Author

Looks like we aren't running Chef::Client#run_ohai and Chef::Client#register. That should do the trick.

@bscott
Copy link

bscott commented May 21, 2013

@josephholsten Thanks, we will start process these PRs shortly. Getting some test specs together first.

@josephholsten
Copy link
Contributor Author

@bscott sounds great. I'm not entirely sure how we're going to test this one since we don't know the node_name until the test runs.

Have you looked at chef-zero? It seems ideal for stubbing out a chef server.

@bscott
Copy link

bscott commented Jun 28, 2013

@josephholsten I'll look into it but we did add some node data but I'm still fighting with tests. I am trying to get our testing in place so we can start accepting pull requests.

@josephholsten
Copy link
Contributor Author

sounds good.

@bscott bscott closed this as completed in efd6e1a Aug 16, 2013
leftathome pushed a commit that referenced this issue Oct 3, 2013
@josephholsten
default node_name to fqdn. fixes #11
2928e54
leftathome pushed a commit that referenced this issue Oct 3, 2013
@josephholsten
default node_name to fqdn. fixes #11
d2eecaf
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@josephholsten @bscott