Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[memory] Fix all deadlocks, implement monitors #316

Merged
merged 42 commits into from
Nov 28, 2023
Merged

[memory] Fix all deadlocks, implement monitors #316

merged 42 commits into from
Nov 28, 2023

Conversation

NikitaZotov
Copy link
Member

@NikitaZotov NikitaZotov commented Sep 23, 2023 •
edited
Loading

@NikitaZotov NikitaZotov self-assigned this Sep 23, 2023
@NikitaZotov NikitaZotov added the 0.9.0 Unlock label Sep 23, 2023
@NikitaZotov NikitaZotov added this to the 0.9.0 milestone Sep 23, 2023
@NikitaZotov NikitaZotov added sc-memory Changes in sc-memory module fs-memory bug Something isn't working sc-events Changes in sc-events module labels Sep 23, 2023
@codecov-commenter
Copy link

codecov-commenter commented Sep 23, 2023 •
edited
Loading

Codecov Report

Attention: 398 lines in your changes are missing coverage. Please review.

Comparison is base (32d9cc8) 77.83% compared to head (a38c389) 86.40%.
Report is 496 commits behind head on main.

Files Patch % Lines
...re/sc-store/sc-fs-memory/sc_dictionary_fs_memory.c 88.50% 89 Missing ⚠️
...c-kpm/sc-ui/translators/uiSc2ScsJsonTranslator.cpp 2.12% 46 Missing ⚠️
...emory/sc-core/sc-store/sc-fs-memory/sc_fs_memory.c 80.00% 40 Missing ⚠️
sc-memory/sc-core/sc-store/sc_storage.c 93.88% 38 Missing ⚠️
sc-memory/sc-core/sc-store/sc_iterator3.c 85.93% 27 Missing ⚠️
...c-store/sc-container/sc-dictionary/sc_dictionary.c 84.88% 26 Missing ⚠️
...pm/sc-search/agents/search_semantic_neighborhood.c 25.80% 23 Missing ⚠️
...c-kpm/sc-ui/translators/uiSc2SCnJsonTranslator.cpp 93.63% 21 Missing ⚠️
...ry/sc-core/sc-store/sc-container/sc-list/sc_list.c 55.31% 21 Missing ⚠️
sc-kpm/sc-common/sc_keynodes.c 6.66% 14 Missing ⚠️
... and 15 more
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #316      +/-   ##
==========================================
+ Coverage   77.83%   86.40%   +8.56%     
==========================================
  Files         226      255      +29     
  Lines       14300    20275    +5975     
==========================================
+ Hits        11131    17519    +6388     
+ Misses       3169     2756     -413
Flag Coverage Δ
unittests 86.40% <89.78%> (+8.56%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@NikitaZotov NikitaZotov force-pushed the fix/deadlocks branch 2 times, most recently from 238cae3 to be97f3d Compare September 24, 2023 08:31
@NikitaZotov NikitaZotov force-pushed the fix/deadlocks branch 3 times, most recently from 8770d48 to 04ab851 Compare September 29, 2023 09:55
@NikitaZotov NikitaZotov force-pushed the fix/deadlocks branch 5 times, most recently from 103ac88 to feefc67 Compare October 21, 2023 22:23
@NikitaZotov
[memory] Optimize segment parallel handling
2d63dbb
@NikitaZotov
[memory] Process management
ec02c36
@NikitaZotov
[memory][tests] Update benchmark tests
ee18815
@NikitaZotov
[memory][refactor] Restruct logs
38d3e46
@NikitaZotov
[memory][tests] Update benchmark tests for sc-links
3cc46dd
@NikitaZotov
[memory][fs-memory] Update fs-memory processes sync
779e4b8
@NikitaZotov
[memory][fs-memory] Optimize links appending
4ad6787
@NikitaZotov
[memory][tests] Update benchmark tests for links
0651ab9
@NikitaZotov
[memory][tests] Fix parallel remove elements
9e29482
@NikitaZotov
[memory] Fix double edge iterations
ccc8c40
@NikitaZotov
[memory][event][context] Fix events and contexts deletion
0a823df
@NikitaZotov
[memory][events][contexts] Reorder memory, events and contexts shutdo…
0305b07 
…wn, add checkings
@NikitaZotov
[memory] Add checking if reuse empty elements
8c1a3a0
@NikitaZotov
[memory][events][refactor] Divide events logic into managers
dd7de75
@NikitaZotov
[memory][context] Refactor memory contexts, implement context manager
0b12eb4
@NikitaZotov
[memory] Restruct processes distribution logic
fb6a519
@NikitaZotov
[memory][fs-memory] Optimize imports, secure interfaces
24d846e
@NikitaZotov
[docs] Apply changes
51d37dd
@NikitaZotov
[memory][fs-memory][tests] Add tests for invalid params
b49a307
@NikitaZotov
[sc-memory][tests] Upgrade iterator3 tests
628b19a
This was linked to issues Nov 28, 2023
Too big number in websocket request crusher sc-server #309
Closed
sc-machine crashes when trying to view a picture in sc-web #311
Closed
Usage of invalid addresses after rerun failed sc-server #79
Closed
No tests for ScMemory::Initialize(sc_memory_params) with different parameters #216
Closed
Fix deadlocks in sc-memory #111
Closed
Handle crush errors #63
Closed
Invalid addrs crushes sc-iterator methods usages #66
Closed
@NikitaZotov NikitaZotov merged commit ac8ed0e into ostis-ai:main Nov 28, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shaversion shaversion shaversion approved these changes

@MksmOrlov MksmOrlov MksmOrlov approved these changes

Assignees

@NikitaZotov NikitaZotov

Labels
0.9.0 Unlock bug Something isn't working fs-memory sc-events Changes in sc-events module sc-memory Changes in sc-memory module
Projects
None yet
Milestone
0.9.0
4 participants
@NikitaZotov @codecov-commenter @MksmOrlov @shaversion