Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌱 Added Repo Urls from GitHub marketplace #3732

Merged
merged 5 commits into from
Jan 8, 2024
Merged

🌱 Added Repo Urls from GitHub marketplace #3732

merged 5 commits into from
Jan 8, 2024

Conversation

manishtiwari25
Copy link
Contributor

@manishtiwari25 manishtiwari25 commented Dec 13, 2023 •
edited
Loading

What kind of change does this PR introduce?

(Is it a bug fix, feature, docs update, something else?)

What is the current behavior?

What is the new behavior (if this is a feature change)?**

  • Tests for the changes have been added (for bug fixes/features)

Which issue(s) this PR fixes

Special notes for your reviewer

Does this PR introduce a user-facing change?

For user-facing changes, please add a concise, human-readable release note to
the release-note

(In particular, describe what changes users might need to make in their
application as a result of this pull request.)

@manishtiwari25 manishtiwari25 requested a review from a team as a code owner December 13, 2023 06:04
@manishtiwari25 manishtiwari25 requested review from justaugustus and spencerschrock and removed request for a team December 13, 2023 06:04
@manishtiwari25 manishtiwari25 changed the title Added URL from GitHub marketplace 🌱 Added URL from GitHub marketplace Dec 13, 2023
@manishtiwari25 manishtiwari25 changed the title 🌱 Added URL from GitHub marketplace 🌱 Added URL from GitHub marketplace Dec 13, 2023
@manishtiwari25 manishtiwari25 changed the title 🌱 Added URL from GitHub marketplace 🌱 Added Repo Urls from GitHub marketplace Dec 13, 2023
spencerschrock
spencerschrock requested changes Dec 19, 2023
View reviewed changes
Copy link
Member

@spencerschrock spencerschrock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. Out of curiosity, are these all of the public GitHub actions? or how was this collected?

I'm going to wait until after the holidays on this. The weekly runs have been slow recently, and I don't want these extra repos to cause us not to finish our runs these next few holiday weeks.

@manishtiwari25
Copy link
Contributor Author

Thanks for the PR. Out of curiosity, are these all of the public GitHub actions? or how was this collected?

I'm going to wait until after the holidays on this. The weekly runs have been slow recently, and I don't want these extra repos to cause us not to finish our runs these next few holiday weeks.

Hey @spencerschrock,
Yes all of them are public repos, I have a script which pull the repo data from here and do some formatting and push it in my forked version and then I did the manual pull request.

@spencerschrock spencerschrock mentioned this pull request Jan 2, 2024
Merged
spencerschrock
spencerschrock approved these changes Jan 8, 2024
View reviewed changes
Copy link
Member

@spencerschrock spencerschrock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should have the quota for these additional repos, but the branch needs to be up-to-date and I'm unable to do so myself.

I'll try to keep an eye out for when you do and try to merge, but granting maintainers access to the branch may be the simpler way.

@spencerschrock spencerschrock enabled auto-merge (squash) January 8, 2024 18:02
@codecov Codecov
Copy link

codecov bot commented Jan 8, 2024

Codecov Report

Merging #3732 (68d09a8) into main (62457a7) will increase coverage by 1.99%.
The diff coverage is n/a.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #3732      +/-   ##
==========================================
+ Coverage   66.40%   68.39%   +1.99%     
==========================================
  Files         229      229              
  Lines       15502    15502              
==========================================
+ Hits        10294    10603     +309     
+ Misses       4595     4248     -347     
- Partials      613      651      +38

@spencerschrock spencerschrock merged commit fdf3fb2 into ossf:main Jan 8, 2024
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justaugustus justaugustus Awaiting requested review from justaugustus justaugustus is a code owner automatically assigned from ossf/scorecard-maintainers

@spencerschrock spencerschrock Awaiting requested review from spencerschrock

Assignees
No one assigned
Labels
waiting-for-feedback
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@manishtiwari25 @spencerschrock