Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove obsolete comment about heightmap pose #565

Merged
merged 1 commit into from
Jan 4, 2023
Merged

Remove obsolete comment about heightmap pose #565

merged 1 commit into from
Jan 4, 2023

Conversation

M1chaelM
Copy link
Collaborator

A simple PR to remove the following comment from our sdfs:

      <!-- Note - the pose tag doesn't seem to work for heightmaps, so you need
      to go into the model file to change the altitude/height! -->

Per discussion in #536 this comment does not seem to be true anymore.

To test

Edit sydney_regatta.sdf to change the pose tag for the sydney_regatta model to alter the z value. Then rebuild and run:

ros2 launch vrx_gz competition.launch.py world:=sydney_regatta

Observe that the pose of the heightmap has changed.

@M1chaelM M1chaelM requested a review from caguero December 30, 2022 21:03
@M1chaelM M1chaelM merged commit b55958e into gazebosim Jan 4, 2023
@caguero caguero deleted the M1chaelM/bad_comment branch January 5, 2023 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@caguero caguero caguero approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@M1chaelM @caguero