[Garden] Wildlife scoring plugin - Part2 #547
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Carlos Agüero <caguero@openrobotics.org>
Signed-off-by: Carlos Agüero <caguero@openrobotics.org>
Signed-off-by: Carlos Agüero <caguero@openrobotics.org>
Signed-off-by: Carlos Agüero <caguero@openrobotics.org>
This was referenced Nov 25, 2022
M1chaelM
approved these changes
Dec 1, 2022
There was a problem hiding this comment.
All works for me! If you have time, I left a few questions and suggestions but all very minor and optional. The only one that we might want to think about relates to our current scoring, which sets the minimum score to 0. I think it would be slightly better (and more aligned with our last documentation) to allow a negative score, but I could be convinced either way as long as we make the documentation consistent.
|
@caguero Thanks for all these helpful responses! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request ports the WildlifeScoringPlugin from Gazebo classic.
How to test it?
/vrx/task/infotopic:Try circumnavigating the buoys (platypus clockwise and turtle counter clockwise). You should see messages of this type:
Bonus: I enabled contact checking again. For some reason the topic subscription was removed.