Removed set pinger position node from vrx.launch as well #439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caguero
approved these changes
Mar 18, 2022
There was a problem hiding this comment.
Thanks for the patch @alexperez33 !. Using vrx.launch and setting the world parameter is correct. In fact this is how we do it in vrx-docker to launch trials.
The only issue here is that if you have a world without a gymkhana scoring plugin, nobody will set the position of the pinger. For example if you launch:
roslaunch vrx_gazebo vrx.launch
The pinger location will default to origin unless you manually call set_pinger_position.py . I think this is not very unreasonable so I'm approving.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@caguero I was able to replicate your fix with success (#438). I noticed that you removed the set_pinger_position node from gymkhana.launch. Would it make sense to remove it from vrx.launch as well (as shown in this PR)? Personally, I have my code set up such that to launch a task, vrx.launch is launched and the world file we want is passed in as an arg. I am not sure if anyone else does it like this, but if they did, they would still run into the pinger issue.
If this is not a viable way that I should go about launching tasks, please let me know! Thanks!