Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Noetic docker #248

Merged
merged 7 commits into from
Jul 7, 2021
Merged

Noetic docker #248

merged 7 commits into from
Jul 7, 2021
+153 −249

Conversation

M1chaelM
Copy link
Collaborator

@M1chaelM M1chaelM commented Jul 6, 2021

To test, please work through the updated VRX Docker Install Tutorial.

@M1chaelM M1chaelM requested review from bsb808, crvogt and caguero July 6, 2021 19:20
@bsb808
Copy link
Collaborator

bsb808 commented Jul 7, 2021

It works for me. The run and join scripts are much simpler now!

I did make some modifications to run.bash in 9aae446 to make use of the CLI argument and parameterize the container name based on the image name - instead of hardcoding.

bsb808
bsb808 approved these changes Jul 7, 2021
View reviewed changes
Copy link
Collaborator

@bsb808 bsb808 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment in conversation. Good to go on my end.

@M1chaelM M1chaelM merged commit c4d7814 into master Jul 7, 2021
@M1chaelM M1chaelM deleted the noetic_docker branch July 7, 2021 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bsb808 bsb808 bsb808 approved these changes

@crvogt crvogt Awaiting requested review from crvogt

@caguero caguero Awaiting requested review from caguero

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@M1chaelM @bsb808