Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to Noetic and Gazebo11 #247

Merged
merged 8 commits into from
Jul 9, 2021
Merged

Migrate to Noetic and Gazebo11 #247

merged 8 commits into from
Jul 9, 2021

Conversation

crvogt
Copy link
Collaborator

@crvogt crvogt commented Jul 6, 2021

PR to update VRX to Noetic/Gazebo11 with Melodic/Gazebo9 compatibility

Mesh Updates

Empty fields in *.dae have been pruned. In Gazebo11, signifying an empty field in a following forward slash format, ie. <librarynotes/>, would result in an error with RViz.

tf_prefix

The global namespace variable is used in favor of the deprecated tf_prefix, apart from usage as a parameter in the robot_localization node.

RViz Examples

RViz examples are now confirmed to work with new config files in both Gazebo9 and 11

To Test

Run roslaunch vrx_gazebo vrx.launch, in another terminal tab roslaunch wamv_gazebo localization_example.launch, and finally roslaunch wamv_gazebo rviz_vrx.launch in another tab.

The resulting RViz window should look like the following:
Screenshot from 2021-07-08 15-47-23

@crvogt crvogt changed the title Added namespace to wamv joints and links, removed old rviz config files Migrate to Noetic Jul 8, 2021
@crvogt crvogt changed the title Migrate to Noetic Migrate to Noetic and Gazebo11 Jul 8, 2021
@crvogt crvogt marked this pull request as ready for review July 8, 2021 22:48
@crvogt crvogt requested a review from caguero July 8, 2021 22:49
@caguero caguero mentioned this pull request Jul 9, 2021
12 tasks
Copy link
Contributor

@caguero caguero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good so far! Could you also update the docker/Dockerfile to use Ubuntu 20.04, Gazebo 11 and ROS Noetic? Never mind, this seems to be ready already.

Copy link
Contributor

@caguero caguero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I confirm that it worked for me in Noetic inside Docker!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants