fix: Add stricter checks to JSON parsing #8229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
directionless
approved these changes
Dec 23, 2023
With CodeQL rules it should be somewhat possible. The main issue is still that C++ is hard to parse and to create the CodeQL database takes time, and you need to do that for each platform. I had it working in the past for Linux, but now I'm updating it to run on Windows and macOS too; on Linux, as far as the object cache can be used, it takes 1h for the workflow to run. Mind that this is all done on free time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I went through or uses of
fromStringand checked where we weren't making sure that the correct root node of the JSON tree was of the correct type.We should also go through all uses of rapidjson and see if all the proper checks when accessing the rest of the JSON nodes are correct (checking that something IsString before doing GetString and so on).