Do not ignore mountpoints that have the same mount path #6871
Conversation
Use a vector instead of an unordered_map keyed on the mount path, since we can have multiple mount points on the same mount path and since all the other use cases do not need such data layout. Although multiple mount points on the same mount path will override each other, we still want to be faithful to the information that /proc/mounts gives us. Moreover with autofs mounted filesystems, we will always have two mount lines when the target filesystem is mounted, one for autofs and one for the target filesytem.
Smjert
force-pushed
the
stefano/fix/missing-mountpoints-autofs
branch
from
fb64557 to
2790d8b
Compare
|
Thank you all! 👏 |
|
@Smjert When do we get this packaged as RPM and when will it be released on https://s3.amazonaws.com/osquery-packages/rpm/x86_64/ or https://osquery.io/downloads/official/ ? |
|
Ping… I really would appreciate this fix as a new RPM release in the official repos being available for my 1000+ Linux Hosts (even if not all hosts use autofs on nfs) 🤔 Can you please give me an estimation when this fix will be made available as a new release? |
|
Sorry for the delay, heads up that packages are available for download shortly after tags are published: https://osquery.io/downloads/official/4.6.0 |
|
But how does it come, that no 4.6.0 is available on |
|
Hi. First, as an aside, this PR did not merge in 4.6.0, it should be in the next release. Second, the package repositories we host tend to lag a bit. This lag is partly to give people a chance to test the new releases, and partly because we're humans. Generally if you're managing a large number of linux machines, I'd recommend hosting your own repos. |
|
We are already mirroring |
|
"too impatient" carries a lot of value. We haven't pushed it to the stable repos because earlier this week we had a report of a potential crash. Though having been unable to reproduce, it will probably go out this week. |
|
Got 4.6.0-1 automatically in Feb 5th 👍🏻 |
Use a vector instead of an unordered_map keyed on the mount path,
since we can have multiple mount points on the same mount path
and since all the other use cases do not need such data layout.
Although multiple mount points on the same mount path will override
each other, we still want to be faithful to the information
that /proc/mounts gives us.
Moreover with autofs mounted filesystems, we will always have two
mount lines when the target filesystem is mounted, one for autofs
and one for the target filesytem.
Fixes #6865