Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: Fix windows build on newer MSVC #6732

Merged
merged 3 commits into from
Oct 28, 2020
Merged

build: Fix windows build on newer MSVC #6732

merged 3 commits into from
Oct 28, 2020

Conversation

sharvilshah
Copy link
Member

Windows build was broken on newer MSVC:
It couldn't find the random_shuffle identifier:

TSocketPool.cpp(191): error C3861: 'random_shuffle': identifier not found

Supersedes #6725

@alessandrogario alessandrogario mentioned this pull request Oct 27, 2020
Merged
muffins
muffins reviewed Oct 27, 2020
View reviewed changes
Copy link
Contributor

@muffins muffins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@sharvilshah
Copy link
Member Author

Thanks @muffins and @Smjert , I think this is good to go!

@directionless directionless merged commit ceeadb5 into osquery:master Oct 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@muffins muffins muffins left review comments

@Smjert Smjert Smjert left review comments

@directionless directionless directionless approved these changes

Assignees
No one assigned
Labels
build Windows
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sharvilshah @Smjert @directionless @muffins