Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: Fix windows build on newer MSVC #6725

Closed
wants to merge 1 commit into from
Closed

build: Fix windows build on newer MSVC #6725

wants to merge 1 commit into from

Conversation

sharvilshah
Copy link
Member

Windows build was broken on newer MSVC:
It couldn't find the random_shuffle identifier:

TSocketPool.cpp(191): error C3861: 'random_shuffle': identifier not found

Turns out we weren't quoting things properly to include the random_shuffle.h patch.
Hat tip to @Smjert for figuring that out.

cc: @muffins

@sharvilshah
Copy link
Member Author

This is now breaking on Linux and macOS, looking...

muffins
muffins approved these changes Oct 23, 2020
View reviewed changes
Copy link
Contributor

@muffins muffins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm! Thanks for the quick fix!

muffins
muffins requested changes Oct 23, 2020
View reviewed changes
Copy link
Contributor

@muffins muffins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah didn't see your note about the breakages, feel free to dismiss my review!

@sharvilshah
Copy link
Member Author

Ah, I broke the other platforms (and older msvc) lol. Looking into it, will update and reopen.

@Smjert
Copy link
Member

Smjert commented Oct 23, 2020

@sharvilshah Try with "SHELL:${forced_include_file_flag} ${CMAKE_CURRENT_SOURCE_DIR}/patches/random_shuffle.h"

@sharvilshah sharvilshah mentioned this pull request Oct 26, 2020
Merged
@sharvilshah
Copy link
Member Author

Thanks for the suggestion @Smjert, but that too couldn't find random_shuffle identifier :(
I have just set forced_include_file_flag based on the platform (in new PR, I forced pushed and can't reopen this one)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@muffins muffins muffins requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sharvilshah @Smjert @muffins