carver: Refactor carver to use the Scheduler #6671
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theopolis
force-pushed
the
carver_refactor
branch
from
cfd9e8c to
5e1ef16
Compare
theopolis
force-pushed
the
carver_refactor
branch
from
5e1ef16 to
75a9fe9
Compare
muffins
reviewed
Sep 27, 2020
There was a problem hiding this comment.
First pass through, overall I love it. The re-arch is very clean and I love the re-arranging for testing. Thanks a ton for taking this on man, it looks great. I'll give it another look through to see if I spot anything else, but generally I think it looks pretty good.
muffins
approved these changes
Oct 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change refactors the carver code and functionality.
From a functionality perspective, carving is now implemented using a request and handler model. Carving can be requested via the SQLite
carvefunction or using the predicateWHERE carve=1on theosquery_carvestable. Previously when a carve was requested, the carving and posting to a remote endpoint would occur during query execution. Now carve requests are buffered and the scheduler thread periodically "wakes up" a carving thread that handles the requests. Additionally, carving is now unique toosquerydand the metadata from successful carve requests will be removed from osquery's internal database after 24hours.From a code point of view the implementation is split into a "carver utilities" set that can be widely used/included. This allows components within osquery to request paths to be carved, as well as a minor amount of inspection into carver statuses. The new "carver" set implements the actual carving and a new "runner" thread to handle carver requests serially. This code should NOT be widely used as it has extensive linkage requirements.