First steps to remove the Buck build system #6361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Smjert
added
build
do not merge
Smjert
requested review from
directionless,
zwass,
theopolis,
muffins,
groob and
alessandrogario
|
This currently depends on #6359, otherwise the build will fail. |
Smjert
force-pushed
the
stefano/build/remove-buck
branch
from
8beae79 to
a2c9ce5
Compare
groob
previously approved these changes
Apr 3, 2020
directionless
previously approved these changes
Apr 3, 2020
There was a problem hiding this comment.
I'm generally in favor of fewer moving parts. And, as I said in #6305, I'm generally going to defer to @theopolis and @muffins on this. But it sounds like they're in favor.
alessandrogario
previously approved these changes
Apr 3, 2020
Smjert
dismissed stale reviews from alessandrogario, directionless, muffins, zwass, and groob
via
c7262d4
Smjert
force-pushed
the
stefano/build/remove-buck
branch
from
a2c9ce5 to
c7262d4
Compare
Smjert
removed
the
do not merge
|
Thanks everyone! |
theopolis
approved these changes
Apr 8, 2020
aikuchin
pushed a commit
to aikuchin/osquery
that referenced
this pull request
Jul 11, 2023
… to master * commit '8c13dd6bd206f2909a4baea5bcfbc91d5e3f502b': (159 commits) release: updating changelog for 4.3.0 release (osquery#6387) Build hvci_status table with CMake (osquery#6378) Change calls to debug log to verbose (osquery#6369) iokit: Fix race when accessing port_ (osquery#6380) Check extensions are registered with osquery core (osquery#6374) First steps to remove the Buck build system (osquery#6361) Return error detaching table, only use primary database (osquery#6373) Copy the parent environment when launching worker Change process table log errors to info and fix typo (osquery#6370) Ensure the extension uuid is never 0 (osquery#6377) Remove errors when converting empty numeric rows (osquery#6371) Do not force a specific path to install osquery on Windows (osquery#6379) Fix readFile API doing blocking I/O with a non-blocking handle (osquery#6368) magic: Check return from magic_file (osquery#6363) macos: Use -1 for missing ppid in process_events (osquery#6339) Update OpenSSL to version 1.1.1f and fix build (osquery#6359) Simplify how third party libraries formula work (osquery#6303) Add socket_events table for socket auditing in MacOS (osquery#6028) Extend the fields of curl_certificate table (osquery#6176) add status column to deb_packages table (osquery#6341) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed here: #6305
This will:
Permit us to reduce some overhead when having to add new tables/features and have them to work with both build systems, especially since we don't have maintainers for Buck.
Permit us to simplify the CMake code, where we had to try to be as most similar to Buck as possible, but it wasn't how standard CMake would have been written.
In general avoid having to maintain too many different methods of dealing with third-party libraries
Free some Azure Pipelines jobs to be possibly used to test other Linux distro which have older kernels than Ubuntu (CentOS?).