logger: Expose max_lines and correct flag types #5956
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Multiple flags are moved from FLAG to CLI_FLAG due to the way they are implemented/used in code. If they were FLAG(s), meaning if they were also configurable via configuration at runtime, the new values would still be ignored. These are: - logger_tls_endpoint - logger_tls_period - logger_tls_max The flag logger_tls_max has been renamed to logger_tls_max_linesize and an alias is added for compatibility. A new flag is added, logger_tls_max_lines, to expose a previously hardcoded value of 1024 for the maximum number of log lines to send every period.
alessandrogario
approved these changes
Oct 28, 2019
|
Relates to #5882 |
theopolis
pushed a commit
to theopolis/osquery
that referenced
this pull request
Oct 29, 2019
This is a follow up to osquery#5956, which reverts the CLI_FLAG changes.
theopolis
added a commit
that referenced
this pull request
Oct 29, 2019
This is a follow up to #5956, which reverts the CLI_FLAG changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Multiple flags are moved from
FLAGtoCLI_FLAGdue to the way they are implemented/used in code. If they wereFLAG(s), meaning if they were also configurable via configuration at runtime, the new values would still be ignored.These are:
logger_tls_endpointlogger_tls_periodlogger_tls_maxThe flag
logger_tls_maxhas been renamed tologger_tls_max_linesizeand an alias is added for compatibility.A new flag is added,
logger_tls_max_lines, to expose a previously hardcoded value of 1024 for the maximum number of log lines to send every period.