Add platform_mask #5898
Merged
Add platform_mask #5898
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Right now, there is no way to tell what platform osquery is running on. We have `os_version.platform` and `os_version.platform_like`, but they are highly inconsistent, and require a lot of custom parsing to use. We should expose the underlying platform bitmask. This adds the `platform_mask` to the `osquery_info` table. This replaces osquery#5488
muffins
approved these changes
Oct 23, 2019
| @@ -11,7 +11,8 @@ schema([ | |||
| Column("build_platform", TEXT, "osquery toolkit build platform"), | |||
| Column("build_distro", TEXT, "osquery toolkit platform distribution name (os version)"), | |||
| Column("start_time", INTEGER, "UNIX time in seconds when the process started"), | |||
| Column("watcher", INTEGER, "Process (or thread/handle) ID of optional watcher process") | |||
| Column("watcher", INTEGER, "Process (or thread/handle) ID of optional watcher process"), | |||
| Column("platform_mask", INTEGER, "The osquery platform bitmask"), | |||
There was a problem hiding this comment.
I like this idea, but aside from searching the code base it might not be entirely obvious what the numeric values map to. Is there somewhere we can document the potential values of this bitmask and then link it in this Column description?
There was a problem hiding this comment.
That's a good question.
I tend to prefer self documenting, but that becomes way too verbose.
I'm leery of making docs, we already have a lot, I think they'll skew. What it we linked to the source code from here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now, there is no way to tell what platform osquery is running on. We have
os_version.platformandos_version.platform_like, but they are highly inconsistent, and require a lot of custom parsing to use. We should expose the underlying platform bitmask.This adds the
platform_maskto theosquery_infotable.This replaces #5488 Contrasting the approaches, I think the I like #5488 more. Exposing the booleans is a better API. This is useful, and better than status quo, but it means we're committing to not changing the bitmask fields