windows/certificates: Fix bug in environment variable expansion #5697
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Maybe @muffins or @theopolis could look? Sorry for all the follow-ons 😅 This should be the last one. |
muffins
reviewed
Aug 8, 2019
I observed rare cases where it would just write 1 wchar_t and return. Add a loop that repeatedly retries up to 100 times before returning failure to the caller.
offlinemark
force-pushed
the
mark/fix/win-certs-env-expand
branch
from
5ae7cdd to
24f6032
Compare
offlinemark
changed the title
alessandrogario
approved these changes
Aug 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a followup to #5640. This should be the last one :)
This fixes a bug in environment variable expansion that occurs when paths to Personal certificate directories are constructed for system accounts.