-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add osquery_platform table #5488
Conversation
9c229e4
to
6610088
Compare
What is the use-case here? Why not just rely on |
I want to know what osquery itself thought the platform was, and by extension, which table schemas would be present. os_version.platform and os_version.platform_like are very different. Those derive from OS presented information, are somewhat incorrect, and can only be manually correlated. with the osquery platforms. Some examples:
|
@fmanco this information is critical to know when enrolling a device in TLS (in fact it is sent during the enrollment request for the remote TLS API). Unfortunately there is no way to dynamically query this information later after the enrollment phase. It just seems strange that something so important to how Osquery identifies systems internally is actually not accessible through a virtual table. |
+1 But having a table all by itself for this also feels awkward. |
@fossam Mostly the columns felt better named in a dedicate table, than adding it elsewhere. Especially if the list of IsPlatform things grows. But, I'm happy to move it. Mostly I wanted the functionality, I'm less picky about where |
This adds an osquery_platform table. This exposes the existing PlatformType bit mask, as well as boolean columns for the existing `isPlatform` types
6610088
to
e837ee0
Compare
This info in a dedicated table seems like overkill. Can you make this work with just the bitmask in osquery_info? |
I could, yes. My thinking here was that it was easier to work with, and it becames self contained. I'm not sure the bitmask will be stable across versions. |
Is this still info we want? |
I would find this content useful, yes. It also feels like something we should expose. I am agnostic whether to add this to a new table, or expand one of the existing ones. Code should be mergeable. |
Let's abandon this and go for a |
Right now, there is no way to tell what platform osquery is running on. We have `os_version.platform` and `os_version.platform_like`, but they are highly inconsistent, and require a lot of custom parsing to use. We should expose the underlying platform bitmask. This adds the `platform_mask` to the `osquery_info` table. This replaces osquery#5488
Right now, there is no way to tell what platform osquery is running on. We have `os_version.platform` and `os_version.platform_like`, but they are highly inconsistent, and require a lot of custom parsing to use. We should expose the underlying platform bitmask. This adds the `platform_mask` to the `osquery_info` table. This replaces osquery#5488
Right now, there is no way to tell what platform osquery is running on. We have `os_version.platform` and `os_version.platform_like`, but they are highly inconsistent, and require a lot of custom parsing to use. We should expose the underlying platform bitmask. This adds the `platform_mask` to the `osquery_info` table. This replaces #5488
This adds an osquery_platform table. This exposes the existing PlatformType bit mask, as well as boolean columns for the existing
isPlatform
types.