Explicitly handle when getUserHomeDir returns empty

osquery · Aug 8, 2019 · b2199dd · b2199dd
1 parent 59a68ad
commit b2199dd
Showing 1 changed file with 5 additions and 0 deletions.
diff --git a/osquery/tables/system/windows/certificates.cpp b/osquery/tables/system/windows/certificates.cpp
@@ -557,6 +557,11 @@ void findUserPersonalCertsOnDisk(const std::string& username,
 
   std::string homeDir;
   auto homeDirUnexpanded = getUserHomeDir(sid);
+  if (homeDirUnexpanded.empty()) {
+    VLOG(1) << "Could not find home dir for account " << username;
+    return;
+  }
+
   // System accounts have environment variables in their paths
   auto ret = expandEnvironmentVariables(homeDirUnexpanded, homeDir);
   if (!ret.ok() || homeDir.empty()) {