-
Notifications
You must be signed in to change notification settings - Fork 368
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CMake updates for embedded code generation #174
Conversation
This should help simplify the code generation CMake, since now the code generation routines can just include the provided CMakeLists.txt in each folder instead of maintaining their own file lists.
Right now the printing fails the timeout test because it runs too fast.
Ok, this is ready for review now. I have also modified the printing test so now it should actually pass (it will timeout in that computation). Once this is merged, it would be good to update the submodules for the develop branches in the repos with code generation. Once that is done, I will make the modifications to the Matlab generation scripts to work with this. |
Thanks a lot for this PR! I have made a branch |
Is this ready to be merged into |
Sure. I will do that |
Yes, I think this is ready to be merged (along with the associated branches in Matlab and Python). |
They are merged now. |
The main portion of the PR is to clean up the CMake list creation so it can simplify the upkeep of the CMake for the code generation routines. This moves the list creation into a CMakeLists inside the src and include folders, so now in code generation frameworks the main CMakeLists should just add these directories instead of having to keep a separate list of the files (which can become out of date as changes are made).
Additionally, the first commit fixes a build error that was introduced recently in embedded mode, and the last commit adds building of the embedded code to the Travis script so that any changes that might break embedded compilation will be caught in CI.