pyatlas now supports Python 3! #576
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
adahn6
reviewed
Dec 11, 2019
| @@ -6,7 +6,7 @@ | |||
| To get setup in a new project folder, run: | |||
|
|
|||
| $ mkdir newproj && cd newproj | |||
| $ virtualenv venv --python=python2.7 | |||
| $ virtualenv venv --python=python3 | |||
adahn6
reviewed
Dec 11, 2019
| @@ -85,6 +87,21 @@ do | |||
| "$protoc_path" "$protofile" --proto_path="$protofiles_dir" --python_out="$pyatlas_root_dir/$pyatlas_srcdir/autogen" || err_shutdown "protoc invocation failed" | |||
| done < <(find "$protofiles_dir" -type f -name "*.proto" -print0) | |||
|
|
|||
| # TODO HACK FIXME this is to fix badly generated import statements by proto3 library | |||
There was a problem hiding this comment.
TODO HACK FIXME
🤣
but for real, thanks for adding this note here for tracking purposes!
adahn6
approved these changes
Dec 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Upgraded
pyatlasto support Python 3! Note that we no longer support Python 2. If you need a Python 2 version ofpyatlas, you can install version5.3.6. But please note that all futurepyatlasupdates will be Python 3 only.We now also use protobuf
3.11.1as opposed toatlas's2.6.1. This should not affectpyatlas's ability to read atlases, as everything should be backwards compatible.Potential Impact:
Downstream users can continue as normal. Those waiting for a Python 3 version are satisfied.
Unit Test Approach:
Same unit test suite as before.
Test Results:
Tests pass. Also opened and played with some old atlas files using the new
pyatlas. Everything seems to be compatible, and protobuf3 is working.In doubt: Contributing Guidelines