Atlas Query Language (AQL) #561
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthieun
requested changes
Nov 13, 2019
There was a problem hiding this comment.
Very nice, thanks @yazad3!
Just some indentation error and cosmetic requests.
It would be nice to also
- add a quick Readme in the
dslpackage, and also link to it in the main readme! - Enable Spotless (it says it support groovy) and maybe have a Checkstyle equivalent!
...ovy/org/openstreetmap/atlas/geography/atlas/dsl/engine/impl/AbstractQueryExecutorImpl.groovy
Outdated
Show resolved
Hide resolved
added 6 commits
November 12, 2019 17:41
|
Hi @matthieun, addressed your items other than spotless, checkstyle. I have done some investigation in this area in the past and it turns out that a lot of tools we use for code quality for Java are encompassed in one tool named CodeNarc. Currently, however there is some noise in the reporting due to the nature of the DSL being built and used and I will need to spend time to configure it in a way it behaves reasonably against this project. Are you ok with a new PR with CodeNarc support? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Atlas Query Language or AQL is a new feature that allows developers to write queries directly against the Atlas files. This will allow rapid development where developers can write
selectstatements against their Atlas or OSM files locally and then port these queries in their applications (spark or otherwise) to run the same queries at scale.AQL currently supports
using(as in use Atlas/OSM files),select,update,delete, explain (as in explain plan),commitanddiff(as in difference between two atlas schemas).The AQL statements (select, update, delete) support complex where clauses with geospatial and tag querying among other criterion. AQL also supports nested inner queries..
AQL leverages Atlas as the underlying framework and doesn't reinvent the wheels. AQL is efficient in the sense that queries are automatically optimized to benefit from
index-ing which can be either atlas id based or geospatial based.Atlas allows working against all 6 major entities,
node,point,edge,line,relation,area, exposed as "tables" in an atlas schema.Potential Impact:
None expected including for groovy-json as it has no new transitive dependencies.
Unit Test Approach:
173 test cases are included.
Test Results:
Tests successful.
In doubt: Contributing Guidelines