File extension is now preserved by the temp file caching strategy #225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MikeGost
previously approved these changes
Sep 25, 2018
matthieun
requested changes
Sep 25, 2018
| @@ -78,6 +80,10 @@ private void compareFetchedResource(final URI resourceURI, final Resource golden | |||
| .get("src/test/resources/org/openstreetmap/atlas/utilities/configuration/feature.json") | |||
| .toAbsolutePath(); | |||
| private static final URI LOCAL_TEST_FILE_2_URI = LOCAL_TEST_FILE_2.toUri(); | |||
| private static final Path LOCAL_TEST_FILE_3 = Paths | |||
| .get("src/test/resources/org/openstreetmap/atlas/utilities/caching/fileNoExt") | |||
There was a problem hiding this comment.
It might not be the right place to say this, but, it would be better to not have hardcoded paths there (in case we change package names in the future, this will be missed).
How about doing this in the tests below:
ByteArrayResource originalFileBytes = new ByteArrayResource();
originalFileBytes.copyFrom(new InputStreamresource(() ->
CachingTests.class.getResourceAsStream("fileNoExt")));
There was a problem hiding this comment.
This is a good call. I think there are a lot of places in the codebase that could use this change.
matthieun
reviewed
Sep 25, 2018
| URI resourceUri; | ||
| try | ||
| { | ||
| resourceUri = CachingTests.class.getResource(LOG4J_PROPERTIES).toURI(); |
There was a problem hiding this comment.
Is log4j.properties used as a random file to test the cache, or did you need it for configuring log4j here?
There was a problem hiding this comment.
It's just a random, non-empty file to test the caching. Should I change it? (I assume it may have logging implications.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
The file extension of a cached resource is now preserved by the temporary file strategy. This makes the changes in this PR unnecessary.
Potential Impact:
This will technically impact any users of
SystemTemporaryFileCachingStrategy. But the impact is all internal and will go unnoticed by users of the class.Unit Test Approach:
Added some additional testing to
CachingTests.testBaseCacheWithGivenStrategyto make sure the file extension saving is working.Test Results:
Test results passed. Additionally, I manually verified that file extensions are saved correctly by checking my local tmp file system.
In doubt: Contributing Guidelines