Adding check in closedLoop method to ensure no duplicate locations. #224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MikeGost
reviewed
Sep 24, 2018
| @@ -152,7 +152,11 @@ public Location center() | |||
| */ | |||
| public Iterable<Location> closedLoop() | |||
| { | |||
| return new MultiIterable<>(this, Iterables.from(this.first())); | |||
| if (this.first() != this.last()) | |||
There was a problem hiding this comment.
Should this be !this.first().equals(this.last()), since the two Locations can be different objects in memory, but we care about actual equality at the latitude/longitude level?
There was a problem hiding this comment.
yes definitely. I will update now.
MikeGost
approved these changes
Sep 24, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This is a very minor update to how the closedLoop function on the polygon object works. Previously it was simply adding the first location to the end of the iteration. This update now just checks to make sure that the last object isn't already equal to the first object, that way we are not simply adding a duplicate location at the end of the iteration.
Potential Impact:
I am not sure if there would be any impact, it is unlikely that this scenario would even be hit under normal circumstances.
Unit Test Approach:
Added a unit test that makes sure that we aren't adding the location at the end if the polygon is already closed.
Test Results:
Test cases passed correctly, and also failed correctly when the update is not included.