Initialize in Construction of AtlasEntityPolygonsFilter #219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MikeGost
approved these changes
Sep 19, 2018
|
@MikeGost multiple threads using the same filter. Caused an NPE in the STRtree code, where the stack trace lead right to the issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Initialize the underlying STRtree in the Rtree class, which lazily constructs its index, when first queried.
This means without querying the Rtree during construction, the filter isn't thread safe despite being read only.
Potential Impact:
Slightly higher memory usage when the filter is never used.
Unit Test Approach:
Standard unit tests should cover because the problem is itself a race condition and cannot be reliably reproduced.
Test Results:
Passes all unit tests.
In doubt: Contributing Guidelines