Double precision in Distance #213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
MikeGost
approved these changes
Sep 6, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Underpin
Distancewith adoubleinstead of alongwhen storing the value as millimeters.Potential Impact:
This changes the
asMillimetersAPI to return adouble. This would allow distance calculations to not lose precision due to rounding to the closest millimeter.Unit Test Approach:
Updated unit tests and also ran all integration tests. Also tried generating Atlas files using
AtlasGeneratorin https://github.com/osmlab/atlas-generator and those look good.Test Results:
Atlas files look good and all unit tests and integration tests pass.
In doubt: Contributing Guidelines