Removing IsoCountry from country code assignment when merging relations #211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This is a left-over from #112. Specifically, we were relying on
IsoCountryTag.first()call, which relies onIsoCountyto get the correct iso3 country code. This would break in case of custom country boundary representations (counties, states, etc.). Instead, we're now relying on aStringrepresentation.Potential Impact:
None really - this will fix multipolygon relation merging for any instance of custom country boundary representations.
Unit Test Approach:
N/A - this is already covered by a unit test, which passes before and after change. See
RelationSlicingTestTest Results:
I tested this on a custom (non
IsoCountry) country code and boundary file, which worked as expected.In doubt: Contributing Guidelines