-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WaySectionProcessor performance improvements #210
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MikeGost
reviewed
Aug 31, 2018
@@ -742,9 +749,16 @@ private boolean isAtlasNode(final WaySectionChangeSet changeSet, final Point poi | |||
private boolean isAtlasPoint(final WaySectionChangeSet changeSet, final Point point) | |||
{ | |||
final boolean hasExplicitOsmTags = pointHasExplicitOsmTags(point); | |||
|
|||
// We use the presence of explicit OSM tagging to determine if it's a point | |||
if (hasExplicitOsmTags) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice cleanup, this makes more sense logically and likely a tiny performance boost.
matthieun
changed the title
DNM: WaySectionProcessor performance improvements
WaySectionProcessor performance improvements
Aug 31, 2018
MikeGost
approved these changes
Aug 31, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great set of changes and tests, thanks @matthieun!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Potential Impact:
Unit Test Approach:
Added a new unit test for ensuring of the cut at the border.
All other tests pass.
Test Results:
The proper number of edges are excluded in the new unit test.
In doubt: Contributing Guidelines