DynamicAtlas improvements: Multi-Atlas loading and hotspots #208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MikeGost
approved these changes
Aug 29, 2018
There was a problem hiding this comment.
This is a great optimization, thanks @matthieun! I'm wondering if there's any way we can test this behavior. From the current implementation - that doesn't look possible.
MikeGost
requested changes
Aug 30, 2018
There was a problem hiding this comment.
Staying consistent with our offline conversation - let's add a field in the DynamicAtlas that can keep track of the number of MultiAtlases built, so we can debug and highlight the number of calls being made. We can then rely on this field (if we expose it) in a test to verify the optimization in this PR.
matthieun
changed the title
matthieun
changed the title
MikeGost
approved these changes
Aug 31, 2018
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Atlas performance improvements:
MultiAtlasunderpinning aDynamicAtlasis already built from the same set of shards, avoid re-loading theMultiAtlas.AbstractAtlasto be faster.BareAtlasPotential Impact:
DynamicAtlascreation should be faster when working with indefinite expansion disabled, and deferred loading enabled, and expansion beyond the initial shard set is not necessary.Unit Test Approach:
DynamicAtlasPreemptiveLoadTestPackedAtlasTest.testLocationContainingTest Results:
All unit/integration tests pass. Raw Atlas Way Sectioning is 9x faster on average.
In doubt: Contributing Guidelines