Adding Direction Tag #206
Merged
Adding Direction Tag #206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR adds a direction tag to Atlas.
The direction tag should be used with two specific conditions on a Node in OSM to provide more information. One usage is to combine highway=MINI_ROUNDABOUT for the directionality of mini-roundabout. Another usage is to combine highway=STOP or highway=GIVE_WAY to represent the Stop/Yield Sign information in detail at the intersection. Detailed combination and impacts are discussed below.
Potential Impact:
The tag value highway=MINI_ROUNDABOUT should be accompanied by direction=CLOCKWISE or direction=ANTICLOCKWISE to represent the directionality of the mini-roundabout.
The tag value highway=STOP or highway=GIVE_WAY should be accompanied by direction=FORWARD or direction=BACKWARD to represent the which direction has to stop/give_way/yield and give priority to rest of traffic directions.
Currently Atlas has no direction tag to deal with any of conditions mentioned above. Adding direction tag will improve the clarity for routing.
Nothing downstream will be impacted as this is solely adding functionality.
Unit Test Approach:
N/A
Test Results:
N/A
In doubt: Contributing Guidelines