Feature concatenate geojson with object properties #205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
ConcatenateGeoJsonCommand assumed that all input geojson features would have only string properties.
This PR resolves the above issue, and simplifies how the features are handled. They are no longer deserialized from json objects to POJOs; rather the features json objects directly added to the "features" array of an enclosing "FeatureCollection"
Potential Impact:
Changes are backward compatible with existing uses of this job.
Unit Test Approach:
Added unit test for new method added to GeoJsonBuilder, and added unit tests for end-to-end file geojson file merging.
Test Results:
All test pass
Describe other (non-unit) test results here.
In doubt: Contributing Guidelines