Fixed Max Width Polygon Enclosure Bug #192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jklamer
approved these changes
Aug 8, 2018
matthieun
approved these changes
Aug 8, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR fixes an issue where a max width polygon (from -180 to 180) would fail to trigger
awtOverflows, which is a method that detects when a certain polygon is too large to be handled by awt Polygon.Potential Impact:
This change will ensure that any Polygon with a width of 0 will use jts instead of awt to calculate
fullyGeometricallyEncloses(Rectangle)orfullyGeometricallyEncloses(Location).Unit Test Approach:
A unit test has been added that checks that a max width polygon can detect a fully enclosed rectangle.
In doubt: Contributing Guidelines