Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update TestAtlasHandler to rely on Raw Atlas Flow #188

Merged
merged 3 commits into from
Aug 8, 2018

Conversation

MikeGost
Copy link
Contributor

@MikeGost MikeGost commented Aug 6, 2018

Description:

There's a number of TestAtlas annotations that build Atlas files from an OSM file (of various formats). Under the covers, these relied on the OsmPbfLoader to construct the Atlas file. This PR updates the Atlas construction to leverage the new Raw Atlas flow for all annotations.

Potential Impact:

This impacts all tests using the annotations.

Unit Test Approach:

There's an existing explicit test (TestAtlasTest) that tests this functionality - which passes after the changes.

Test Results:

All other unit tests that rely on the annotations are passing after the test, implying the constructed Atlas is valid.


In doubt: Contributing Guidelines

Copy link
Collaborator

@matthieun matthieun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clean and simple!

@matthieun matthieun merged commit e20286d into osmlab:dev Aug 8, 2018
@matthieun matthieun added this to the 5.1.7 milestone Aug 9, 2018
@MikeGost MikeGost deleted the testUpdate branch August 31, 2018 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants