Overlapping allowed in AtlasEntityPolygonsFilter #182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MikeGost
requested changes
Jul 26, 2018
| @Test | ||
| @Ignore |
There was a problem hiding this comment.
Instead of ignoring, let's update it to reflect updated behavior or remove it altogether.
MikeGost
approved these changes
Jul 27, 2018
matthieun
approved these changes
Jul 27, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Originally the
AtlasEntityPolygonFilterdidn't allow overlapping Surfaces because it allowed both Include and Exclude Surfaces, and the only way to avoid ambiguous behavior was to not allow overlapping. Overlapping is now allowed because this expands the usability and makes more sense, given if an entity is included in two overlapping surfaces or excluded in two overlapping surfaces, the behavior is the same.