Fix error catching issues in travis build #178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Good, it failed! |
jwpgage
reviewed
Jul 17, 2018
| new FileOutputStream(outputFile)); | ||
| final InputStream inputStream = file.getInputStream(current)) |
There was a problem hiding this comment.
Why were all these final keywords removed?
There was a problem hiding this comment.
There is a checkstyle rule saying those are redundant.
There was a problem hiding this comment.
atlas/config/checkstyle/checkstyle.xml
Line 67 in 0f108ce
|
LGTM! Thanks @matthieun |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This might be a resolution for #165