Fix code smells #175
Merged
Fix code smells #175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MikeGost
approved these changes
Jul 16, 2018
| outputFile.getParentFile().mkdirs(); | ||
| NotifyingIOUtils.copy(inputStream, bos, | ||
| new Progress(outputFile, current.getSize())); | ||
| IOUtils.closeQuietly(inputStream); |
There was a problem hiding this comment.
Are the two closeQuietly calls still needed? close() is implicitly called by the try-with-resource block.
There was a problem hiding this comment.
I weighed removing them, then decided not to, to avoid changing the behavior. In this case, close quietly would close it and not return an exception if it fails closing. The question is would it fail again anyway once the implicit finally block tries to close it again...? In which case I can remove those calls.
There was a problem hiding this comment.
Hmm good point. Maybe worth testing with and without the calls.
There was a problem hiding this comment.
Ok, let me add a unit test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing those code smells from the sonar report:
https://sonarcloud.io/project/issues?id=org.openstreetmap.atlas%3Aatlas&issues=AWSBg5Cbl6vpliCeK6yK&open=AWSBg5Cbl6vpliCeK6yK
https://sonarcloud.io/project/issues?id=org.openstreetmap.atlas%3Aatlas&issues=AWSBg5E3l6vpliCeK60I&open=AWSBg5E3l6vpliCeK60I
https://sonarcloud.io/project/issues?id=org.openstreetmap.atlas%3Aatlas&issues=AWSBg4zyl6vpliCeK6qK&open=AWSBg4zyl6vpliCeK6qK
https://sonarcloud.io/project/issues?id=org.openstreetmap.atlas%3Aatlas&issues=AWSBg4zyl6vpliCeK6qL&open=AWSBg4zyl6vpliCeK6qL
https://sonarcloud.io/project/issues?id=org.openstreetmap.atlas%3Aatlas&issues=AWSBg489l6vpliCeK6t2&open=AWSBg489l6vpliCeK6t2
https://sonarcloud.io/project/issues?id=org.openstreetmap.atlas%3Aatlas&issues=AWSBg489l6vpliCeK6t3&open=AWSBg489l6vpliCeK6t3
https://sonarcloud.io/project/issues?id=org.openstreetmap.atlas%3Aatlas&issues=AWSBg5BHl6vpliCeK6wH&open=AWSBg5BHl6vpliCeK6wH