Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optionally skip slow OSProcess fields #689

Merged
merged 1 commit into from
Nov 21, 2018
Merged

Optionally skip slow OSProcess fields #689

merged 1 commit into from
Nov 21, 2018

Conversation

dbwiddis
Copy link
Member

Fixes #677

@codecov-io
Copy link

codecov-io commented Nov 20, 2018

Codecov Report

Merging #689 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #689   +/-   ##
=========================================
  Coverage     83.64%   83.64%           
  Complexity      198      198           
=========================================
  Files            28       28           
  Lines          1480     1480           
  Branches        214      214           
=========================================
  Hits           1238     1238           
  Misses          116      116           
  Partials        126      126
Impacted Files Coverage Δ Complexity Δ
...rc/main/java/oshi/software/os/OperatingSystem.java 100% <ø> (ø) 0 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 23bea1b...6124672. Read the comment docs.

@coveralls
Copy link

coveralls commented Nov 20, 2018

Coverage Status

Coverage remained the same at 91.014% when pulling 6124672 on dbwiddis:master into 23bea1b on oshi:master.

@dbwiddis
Copy link
Member Author

This pull request introduces 2 alerts when merging 6124672 into 23bea1b - view on LGTM.com

new alerts:

  • 2 for Dereferenced variable may be null

Comment posted by LGTM.com

@dbwiddis dbwiddis merged commit 09f16c0 into oshi:master Nov 21, 2018
@stefan-reich
Copy link
Contributor

Works great! Listing all processes is down to 100 to 200 ms on my Linux machine. Sure, I'd like it even faster (so I can alwas have it running), but it's definitely workable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants