Coverage remained the same at 81.02% when pulling 9197746 on 2kindsofcs:specialize-getHostName into b7ff327 on oshi:master.

Codecov Report

Merging #1008 into master will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #1008   +/-   ##
=========================================
  Coverage     77.17%   77.17%           
  Complexity        2        2           
=========================================
  Files            23       23           
  Lines          1196     1196           
  Branches        154      154           
=========================================
  Hits            923      923           
  Misses          206      206           
  Partials         67       67

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b7ff327...9197746. Read the comment docs.

I have a question. contributing guide says "Update CHANGELOG Again" and I'm somewhat confused. Do I have to update changelog at the moment I made a pull request or when my pull request got merged?

The idea here is that the first time you complete the change log you don't know the number of your pull request (you can try to guess by looking at the next sequential issue/pull request number) so you would do another commit to insert the number. When that document was originally written, the request was to use an "amend" commit to minimize the number of actual commits to the project. Since then, Github has added a "Squash and merge" option that combines all commits for a PR into one so there's no need to do an "amend" commit (but you're welcome to do so).

This looks good! Ready to merge... I might make a few tweaks on the inheritance first, as I realized (belatedly) that we should just make the CLibrary class inherit from the JNA LibCAPI. Then there are some functions that we can remove from the CLibrary. Happy to do that unless you want to make yet another change. :)

Did you want to make a changelog entry or are you good to go with this as is?

Looks good! I'll let the CI tests run and tweak the C library inheritance again and merge within the hour. Thanks for contributing to open source!

I checked my code once again and found that 2 files don't have "NOSONAR" footnote while there is import com.sun.jna.Native. so I added a footnote for each file.
and I updated the changelog! I appreciate your kindness and effort to help someone who wants to contribute to an opensource project but inexperienced. For those a couple of days, I was enjoying adding some code to a huge project source code that I didn't write and it was truly pleasing and thrilling.