Combinatorics: added in(::Int, ::Edge), signed_incidence_matrix(::Graph{Undirected}), connectivity(::Graph{Undirected}) #4450
Conversation
YueRen
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4450 +/- ##
==========================================
- Coverage 84.42% 84.41% -0.02%
==========================================
Files 668 668
Lines 88363 88441 +78
==========================================
+ Hits 74600 74657 +57
- Misses 13763 13784 +21
|
YueRen
changed the title
There was a problem hiding this comment.
It might be too late to change, but here vertices seem to be integers? So in particular they are not tied to any specific graph? I'd expect s/th/ like v = G(1) to create a vertex in G, then v in some edge makes sense to me. Alternatively, V = vertices(G), v = V(1), ...
No, graphs, edges, and vertices in Oscar are not smart like that. The vertices of a graph To a certain degree this is consistent with polytopes and polyhedral complexes, whose vertices are simple |
Co-authored-by: Benjamin Lorenz <benlorenz@users.noreply.github.com>
Should both be added now. |
in(::Int, ::Edge)is self-explanatorysigned_incidence_matrix(::Graph{Undirected})andconnectivity(::Graph{Undirected})for undirected graphs should work exactly as in polymake (I just relaxed the signature of the julia function)