Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mjrodgers ow g modules #4108

Open
wants to merge 34 commits into
base: master
Choose a base branch
from
Open

Mjrodgers ow g modules #4108

wants to merge 34 commits into from

Conversation

fieker
Copy link
Contributor

@fieker fieker commented Sep 18, 2024

No description provided.

@fieker fieker force-pushed the mjrodgers-OW_GModules branch 2 times, most recently from 0c125cd to 6d4c896 Compare September 26, 2024 14:42
@lgoettgens lgoettgens added the experimental Only changes experimental parts of the code label Sep 26, 2024
mjrodgers and others added 16 commits October 28, 2024 09:37
the "same" should work for Pc - but we don't have the interface to
sanely query the pc-relations (yet)
create an Oscar collector from a GAP collector
Co-authored-by: Lars Göttgens <lars.goettgens@gmail.com>
the following should/ will work:

  C = trivial_gmodule(pc_group(symmetric_group(4)), abelian_group([2,3]))
  q = cohomology_group(C, 2);
  h = q[2](q[1][1])
  E = extension(h)

  m1 = isomorphism(FPGroup, E)
  m2 = isomorphism(PcGroup, E)

  is_isomorphic(codomain(m1), codomain(m2))

However, m2 will not work as a map, there is code missing to legally
convert a syllable back into a PcGroup

Or a shiftgens for PcGroups

The syllables function for Pc is possibly dodgy
create an Oscar collector from a GAP collector
@fieker fieker force-pushed the mjrodgers-OW_GModules branch from dd53042 to 5f02019 Compare October 28, 2024 08:39
via abelian groups. This should work now:

Zx, x = ZZ[:x];
k, a= number_field(swinnerton_dyer(4, x))
zk = lll(maximal_order(k))
p2 = prime_decomposition(zk, 2);
C, mC = completion(k, p2[1][1]);
G = gmodule(C);
z = free_abelian_group(1)
h = hom((G[1]).M, z, [z([Int(absolute_ramification_index(C)*valuation(G[3](x)))]) for x = gens((G[1]).M)])
hom(G[1], trivial_gmodule((G[1]).G, z), h)
U = kernel(ans)
cohomology_group(U[1], 1)[1]
fieker and others added 7 commits November 28, 2024 13:59
create an Oscar collector from a GAP collector
Note that `conductor` got corrected in a previous commit.
- call `extension(FPGroup, c)` instead of `extension(c)`
- in `invariant_lattice_classes`, put not the result of `sub`
  into the result but its first component
- a prescribed test result was wrong, now it is corrent
- `Map{T1,T2}` does actually not match the type of a
  `AbstractAlgebra.Generic.ModuleHomomorphism`
  (although domain and codomain are correct)
@ThomasBreuer
Copy link
Member

@fieker Commit 1cd8833 proposes some syntax changes in order to make the tests pass. I am not sure that this is a good solution.
The problem was that extension(c) was called where apparently the two argument version extension(FPGroup, c) is needed.
(Where is the variant extension(c) needed, which returns a GrpExt object?)

Copy link

codecov bot commented Dec 13, 2024

Codecov Report

Attention: Patch coverage is 16.04278% with 157 lines in your changes missing coverage. Please review.

Project coverage is 84.25%. Comparing base (23b0b9d) to head (b81c70e).
Report is 49 commits behind head on master.

Files with missing lines Patch % Lines
experimental/GModule/src/GrpExt.jl 1.78% 110 Missing ⚠️
experimental/GModule/src/Types.jl 25.00% 30 Missing ⚠️
experimental/GModule/src/GModule.jl 40.00% 15 Missing ⚠️
experimental/GModule/src/Misc.jl 50.00% 1 Missing ⚠️
src/Rings/AbelianClosure.jl 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4108      +/-   ##
==========================================
- Coverage   84.40%   84.25%   -0.15%     
==========================================
  Files         656      669      +13     
  Lines       87216    88778    +1562     
==========================================
+ Hits        73612    74800    +1188     
- Misses      13604    13978     +374     
Files with missing lines Coverage Δ
experimental/GModule/src/Cohomology.jl 72.72% <100.00%> (-0.87%) ⬇️
experimental/GModule/test/runtests.jl 100.00% <ø> (ø)
src/GAP/iso_oscar_gap.jl 98.26% <100.00%> (+<0.01%) ⬆️
experimental/GModule/src/Misc.jl 45.59% <50.00%> (+0.03%) ⬆️
src/Rings/AbelianClosure.jl 94.12% <66.66%> (-0.16%) ⬇️
experimental/GModule/src/GModule.jl 63.34% <40.00%> (-0.51%) ⬇️
experimental/GModule/src/Types.jl 25.00% <25.00%> (ø)
experimental/GModule/src/GrpExt.jl 36.19% <1.78%> (-28.03%) ⬇️

... and 81 files with indirect coverage changes

@fieker
Copy link
Contributor Author

fieker commented Dec 16, 2024

looks good! Clearly we need more tests... but that is independent of this PR

@fieker
Copy link
Contributor Author

fieker commented Dec 16, 2024 via email

@ThomasBreuer
Copy link
Member

test (nightly, book, Linux, RPTU, normal-memory) failed twice, got cancelled after 2.5 hours.
Perhaps this pull request slows down the computations?

@joschmitt
Copy link
Member

test (nightly, book, Linux, RPTU, normal-memory) failed twice, got cancelled after 2.5 hours. Perhaps this pull request slows down the computations?

This is just #4402.

Co-authored-by: Lars Göttgens <lars.goettgens@rwth-aachen.de>
@mjrodgers
Copy link
Collaborator

After discussing today with @ThomasBreuer this looks ready to merge; changes discussed with @fieker to get a map returned form can_be_defined_over_with_data will come separately (I can get a PR set up tomorrow), they are unrelated to the other changes here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
experimental Only changes experimental parts of the code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants