Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: don't require code credential for MFA flows #3753

Merged
merged 1 commit into from
Feb 16, 2024
Merged

fix: don't require code credential for MFA flows #3753

merged 1 commit into from
Feb 16, 2024

Conversation

jonas-jonas
Copy link
Member

@jonas-jonas jonas-jonas commented Feb 13, 2024 •
edited
Loading

Removes the requirement to set the phone number as a code credential in the identity schema for MFA via SMS, as we already have the identity from the session in MFA flows and can use it from there.

Related issue(s)

Checklist

  • I have read the contributing guidelines.
  • I have referenced an issue containing the design document if my change
    introduces a new feature.
  • I am following the
    contributing code guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security vulnerability, I
    confirm that I got the approval (please contact
    security@ory.sh) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

Further Comments

@jonas-jonas jonas-jonas self-assigned this Feb 13, 2024
@codecov Codecov
Copy link

codecov bot commented Feb 13, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (cfa3074) 78.05% compared to head (ac4cd80) 78.39%.

Files Patch % Lines
selfservice/strategy/code/strategy_login.go 81.81% 1 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #3753      +/-   ##
==========================================
+ Coverage   78.05%   78.39%   +0.33%     
==========================================
  Files         355      347       -8     
  Lines       24836    23911     -925     
==========================================
- Hits        19386    18745     -641     
+ Misses       3962     3755     -207     
+ Partials     1488     1411      -77

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jonas-jonas jonas-jonas marked this pull request as ready for review February 13, 2024 15:19
@jonas-jonas jonas-jonas requested a review from zepatrik February 14, 2024 14:28
@aeneasr aeneasr merged commit 40ed809 into master Feb 16, 2024
33 checks passed
@aeneasr aeneasr deleted the jonas-jonas/dontRequireCodeCredential branch February 16, 2024 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zepatrik zepatrik zepatrik approved these changes

@aeneasr aeneasr aeneasr approved these changes

@hperl hperl Awaiting requested review from hperl

Assignees

@jonas-jonas jonas-jonas

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jonas-jonas @aeneasr @zepatrik