Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update security scanners #3295

Merged
merged 6 commits into from
May 30, 2023
Merged

chore: update security scanners #3295

merged 6 commits into from
May 30, 2023

Conversation

Demonsthere
Copy link
Contributor

@Demonsthere Demonsthere commented May 30, 2023 •
edited
Loading

Related issue(s)

Checklist

  • I have read the contributing guidelines.
  • I have referenced an issue containing the design document if my change
    introduces a new feature.
  • I am following the
    contributing code guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security vulnerability, I
    confirm that I got the approval (please contact
    security@ory.sh) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

Further Comments

  • Update CVE scanners
  • Use proper image for scans, instead of a dummy one
  • Update system versions
  • Dockerfile good practices

@Demonsthere Demonsthere marked this pull request as ready for review May 30, 2023 07:37
@Demonsthere Demonsthere added the area/ci This issue affects Ory's CI. label May 30, 2023
jonas-jonas
jonas-jonas approved these changes May 30, 2023
View reviewed changes
Copy link
Member

@jonas-jonas jonas-jonas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codeball is timing out... some issue on their end, I guess.

@codecov
Copy link

codecov bot commented May 30, 2023

Codecov Report

Merging #3295 (3d59efd) into master (387f5a2) will decrease coverage by 0.01%.
The diff coverage is n/a.

❗ Current head 3d59efd differs from pull request most recent head bacb88f. Consider uploading reports for the commit bacb88f to get more accurate results

@@            Coverage Diff             @@
##           master    #3295      +/-   ##
==========================================
- Coverage   77.64%   77.63%   -0.01%     
==========================================
  Files         325      325              
  Lines       20511    20511              
==========================================
- Hits        15925    15923       -2     
- Misses       3367     3368       +1     
- Partials     1219     1220       +1

see 1 file with indirect coverage changes

@Demonsthere Demonsthere enabled auto-merge (squash) May 30, 2023 07:56
@Demonsthere Demonsthere merged commit ac96a96 into ory:master May 30, 2023
@Demonsthere Demonsthere deleted the chore/cve-pipeline branch May 30, 2023 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonas-jonas jonas-jonas jonas-jonas approved these changes

@aeneasr aeneasr Awaiting requested review from aeneasr aeneasr is a code owner

@zepatrik zepatrik Awaiting requested review from zepatrik

Assignees
No one assigned
Labels
area/ci This issue affects Ory's CI.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Demonsthere @jonas-jonas