Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update quickstart configuration to current version, enable 2FA #2828

Merged
merged 1 commit into from
Oct 26, 2022
Merged

fix: update quickstart configuration to current version, enable 2FA #2828

merged 1 commit into from
Oct 26, 2022

Conversation

mmeller-wikia
Copy link
Contributor

@mmeller-wikia mmeller-wikia commented Oct 21, 2022 •
edited
Loading

Fix quickstart configuration and enable 2FA in quickstart

Related issue(s)

Checklist

  • I have read the contributing guidelines.
  • I have referenced an issue containing the design document if my change
    introduces a new feature.
  • I am following the
    contributing code guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security vulnerability, I
    confirm that I got the approval (please contact
    security@ory.sh) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

Further Comments

Tests and documentation checks are not relevant to this change -> unchecked.

@mmeller-wikia
Copy link
Contributor Author

Hi @jonas-jonas
This is a fairly simple fix, but I believe it is important for Kratos adoption (creating PoC should be as simple as possible).

@mmeller-wikia mmeller-wikia force-pushed the fix-quickstart-setup branch 2 times, most recently from 4215aa0 to 6ce9185 Compare October 21, 2022 07:52
@codecov
Copy link

codecov bot commented Oct 21, 2022 •
edited
Loading

Codecov Report

Merging #2828 (0c85146) into master (816b029) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #2828   +/-   ##
=======================================
  Coverage   75.89%   75.89%           
=======================================
  Files         302      302           
  Lines       17824    17824           
=======================================
  Hits        13528    13528           
  Misses       3259     3259           
  Partials     1037     1037

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@jonas-jonas
Copy link
Member

Hi, thanks! Yes you're right. The code keys are new configuration values, and they currently only work if you build the container locally.

These keys should be added back, though, once we make another kratos release. @aeneasr PTAL aswell.

zepatrik
zepatrik reviewed Oct 25, 2022
View reviewed changes
Copy link
Member

@zepatrik zepatrik left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code keys are new configuration values, and they currently only work if you build the container locally.

That's why the quickstart starts with

git clone https://github.com/ory/kratos.git
cd kratos
git checkout v0.10.1
docker-compose -f quickstart.yml -f quickstart-standalone.yml up --build --force-recreate
# If you have SELinux, run:
docker-compose -f quickstart.yml -f quickstart-selinux.yml -f quickstart-standalone.yml up --build --force-recreate

so that you check out the latest release.

I suggest we keep the code setting, but we can add the other 2fa related settings 👍

@mmeller-wikia
Copy link
Contributor Author

The code keys are new configuration values, and they currently only work if you build the container locally.

That's why the quickstart starts with

git clone https://github.com/ory/kratos.git
cd kratos
git checkout v0.10.1
docker-compose -f quickstart.yml -f quickstart-standalone.yml up --build --force-recreate
# If you have SELinux, run:
docker-compose -f quickstart.yml -f quickstart-selinux.yml -f quickstart-standalone.yml up --build --force-recreate

so that you check out the latest release.

I suggest we keep the code setting, but we can add the other 2fa related settings 👍

Done in 0c85146

But IMHO it would be nice to link quick-start in this section https://github.com/ory/kratos#getting-started (there is a link https://www.ory.sh/docs/examples instead Kratos setup)

@mmeller-wikia
Copy link
Contributor Author

@zepatrik
PR is ready for CR :)

@zepatrik zepatrik merged commit 8f52e8b into ory:master Oct 26, 2022
@zepatrik
Copy link
Member

@tomekpapiernik maybe it would be better to add all the quickstarts to the examples page?

peturgeorgievv pushed a commit to senteca/kratos-fork that referenced this pull request Jun 30, 2023
@mmeller-wikia
docs: enable 2FA methods in docker-compose quickstart setup (ory#2828)
0881119
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zepatrik zepatrik zepatrik approved these changes

@aeneasr aeneasr Awaiting requested review from aeneasr aeneasr is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mmeller-wikia @jonas-jonas @zepatrik