Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: format using Make #3257

Merged
merged 9 commits into from
Sep 22, 2022
Merged

chore: format using Make #3257

merged 9 commits into from
Sep 22, 2022

Conversation

kevgo
Copy link
Contributor

@kevgo kevgo commented Sep 15, 2022

Addresses parts of https://github.com/ory-corp/general/issues/735.

Checklist

  • I have read the contributing guidelines.
  • I have referenced an issue containing the design document if my change
    introduces a new feature.
  • I am following the
    contributing code guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security. vulnerability, I
    confirm that I got green light (please contact
    security@ory.sh) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

@kevgo kevgo requested a review from aeneasr as a code owner September 15, 2022 14:45
@codecov
Copy link

codecov bot commented Sep 15, 2022 •
edited
Loading

Codecov Report

Merging #3257 (927dd0b) into master (be24b80) will decrease coverage by 0.02%.
The diff coverage is n/a.

❗ Current head 927dd0b differs from pull request most recent head d9eb1b2. Consider uploading reports for the commit d9eb1b2 to get more accurate results

@@            Coverage Diff             @@
##           master    #3257      +/-   ##
==========================================
- Coverage   76.82%   76.80%   -0.03%     
==========================================
  Files         123      123              
  Lines        8845     8845              
==========================================
- Hits         6795     6793       -2     
- Misses       1626     1627       +1     
- Partials      424      425       +1
Impacted Files Coverage Δ
client/handler.go 79.42% <ø> (ø)
consent/handler.go 65.33% <ø> (ø)
flow/flow.go 92.17% <ø> (ø)
health/doc.go 0.00% <ø> (ø)
jwk/handler.go 64.44% <ø> (ø)
oauth2/handler.go 68.51% <ø> (ø)
oauth2/trust/handler.go 76.27% <ø> (ø)
persistence/sql/persister_oauth2.go 82.12% <0.00%> (-0.77%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@kevgo kevgo merged commit 15cdb88 into ory:master Sep 22, 2022
@kevgo kevgo deleted the kg-format-makefile branch September 22, 2022 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zepatrik zepatrik zepatrik approved these changes

@aeneasr aeneasr Awaiting requested review from aeneasr aeneasr is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kevgo @zepatrik